Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify valid key types #2266

Merged
merged 1 commit into from May 24, 2023
Merged

Clarify valid key types #2266

merged 1 commit into from May 24, 2023

Conversation

cydanil
Copy link
Contributor

@cydanil cydanil commented May 21, 2023

Hi,
This PR aims to close #2233 , where it's suggested to clarify that only strings and bytes are valid key types.

Thanks!
Cyril

@codecov
Copy link

codecov bot commented May 21, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.17 ⚠️

Comparison is base (2332968) 89.96% compared to head (971b1e9) 89.79%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2266      +/-   ##
==========================================
- Coverage   89.96%   89.79%   -0.17%     
==========================================
  Files          17       17              
  Lines        2382     2392      +10     
==========================================
+ Hits         2143     2148       +5     
- Misses        239      244       +5     
Impacted Files Coverage Δ
h5py/_hl/base.py 95.95% <100.00%> (+0.03%) ⬆️

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@cydanil cydanil changed the title Clarify valid keys type Clarify valid key types May 21, 2023
@takluyver takluyver added this to the 3.9 milestone May 24, 2023
@takluyver
Copy link
Member

Thanks Cyril!

@takluyver takluyver merged commit 389eb5f into h5py:master May 24, 2023
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

h5 dictionaries can't handle numerical keys
2 participants