Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for AWS session token #2301

Merged
merged 4 commits into from Oct 6, 2023
Merged

Conversation

ajelenak
Copy link
Contributor

This token can now be used by the ros3 driver as part of AWS temporary security credentials.

@codecov
Copy link

codecov bot commented Aug 27, 2023

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (89e1e2e) 89.77% compared to head (edeae4b) 89.55%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2301      +/-   ##
==========================================
- Coverage   89.77%   89.55%   -0.23%     
==========================================
  Files          17       17              
  Lines        2377     2384       +7     
==========================================
+ Hits         2134     2135       +1     
- Misses        243      249       +6     
Files Coverage Δ
h5py/_hl/files.py 86.08% <25.00%> (-1.89%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ajelenak
Copy link
Contributor Author

ajelenak commented Oct 5, 2023

Just pushed a commit that resolves an issue related to the 1.10 API upgrade. Since this PR is already a month old, I will merge it tomorrow. It should be really good to have it in the next release.

@ajelenak ajelenak merged commit a4f80bd into h5py:master Oct 6, 2023
38 of 39 checks passed
@ajelenak ajelenak deleted the ros3-token branch October 6, 2023 18:17
@takluyver takluyver added this to the 3.10 milestone Oct 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants