New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement MultiManager and low level H5Dread_multi call #2351
Open
mattjala
wants to merge
14
commits into
h5py:master
Choose a base branch
from
mattjala:dset_multi
base: master
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 2 commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
652b0c2
Implement low level H5Dread_multi call
mattjala e336b9c
Handle HDF5 versions < 1.14.0
mattjala f0dea55
Separate read_multi case into dset_rw_multi
mattjala 4da8e24
Support write/read_multi through rw_multi
mattjala 7e8c92e
Implement high-level MultiManager for multi r/w
mattjala 097bf48
Fix scalar broadcasting on MultiManager
mattjala 186be96
Add datatype tests
mattjala 590446d
Document MultiManager usage
mattjala a3c28b6
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 66a8b33
Publicly expose MultiManager
mattjala 1a8cd8a
Support distinct selections on MultiManager
mattjala a751e8f
Document MultiManager multi-selection
mattjala fef44c3
Test multi selection with a field
mattjala 8ba2be3
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These parameters are lists instead of numpy arrays to avoid an issue with the destination buffers.
Specifically, the individual destination buffer for each dset read should be a numpy array. If
bufs
were itself also a numpy array containing these arrays, then it would copy those arrays instead of pointing to the same memory, and the original destination arrays the user created wouldn't get populated.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, that makes sense.
The Python function probably shouldn't take
count
as the first parameter - it's necessary in C to tell you how many items you can read after a pointer, but lists have a length.But if that's the case, I'd probably do a check up front that the lists are all the same length, and fail with a clear error if not.