Creates access to remaining H5O_info_t struct fields, Closes #2347 #2358
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2358 +/- ##
=======================================
Coverage 89.53% 89.53%
=======================================
Files 17 17
Lines 2380 2380
=======================================
Hits 2131 2131
Misses 249 249 ☔ View full report in Codecov by Sentry. |
h5py/h5o.pyx
Outdated
| cdef class _MetaSizeObj(_ObjInfoBase): | ||
|
|
||
| property index_size: | ||
| def __get__(self): | ||
| return self.istr[0].meta_size.obj.index_size | ||
| property heap_size: | ||
| def __get__(self): | ||
| return self.istr[0].meta_size.obj.heap_size | ||
|
|
||
| def _hash(self): | ||
| return hash((self.index_size, self.heap_size)) | ||
|
|
||
| cdef class _MetaSizeAttr(_ObjInfoBase): | ||
|
|
||
| property index_size: | ||
| def __get__(self): | ||
| return self.istr[0].meta_size.attr.index_size | ||
| property heap_size: | ||
| def __get__(self): | ||
| return self.istr[0].meta_size.attr.heap_size | ||
|
|
||
| def _hash(self): | ||
| return hash((self.index_size, self.heap_size)) |
There was a problem hiding this comment.
I think these two classes can be condensed into one - we'll need two instances, but the corresponding C structs are of the same type (H5_ih_info_t).
There was a problem hiding this comment.
Yes, I tried to make them one but was struggling with the Cython code to access attr vs obj field from self.istr[0].meta_size.
Its all very new to me. I'll take another crack.
There was a problem hiding this comment.
I believe I got it working. It built and I was able to access the structs in ipython.
In [1]: import h5py
In [2]: h5py.__file__
Out[2]: '/home/delen/miniconda3/envs/h5py_dev/lib/python3.10/site-packages/h5py/__init__.py'
In [3]: from h5py.h5o import get_info
In [4]: h5 = h5py.File("./h5py/h5py/tests/data_files/vlen_string_dset.h5")
In [5]: get_info(h5['DS1'].id).meta_size.obj.index_size
Out[5]: 0
In [6]: get_info(h5['DS1'].id).meta_size.attr.index_size
Out[6]: 0
In [7]: get_info(h5['DS1'].id).meta_size.attr.heap_size
Out[7]: 0
In [8]: get_info(h5['DS1'].id).meta_size.obj.heap_size
Out[8]: 0
|
Other than that, these changes look good to me. |
…istantiated twice
|
Thanks, this looks good to me. Could I ask you to add a news entry for it? https://docs.h5py.org/en/stable/contributing.html#write-a-release-note |
for more information, see https://pre-commit.ci
Delengowski
changed the title
|
Closes #2347 |
|
Thanks @Delengowski ! |
These are just exposing additional fields of
H5O_info_tstruct and has no direct interface on high level classes so I don't think tests are necessary. Let me know if otherwise.