Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try building with numpy 2.0 rc1 #2401

Merged
merged 5 commits into from Apr 3, 2024
Merged

Conversation

takluyver
Copy link
Member

See discussion on #2353.

@takluyver takluyver mentioned this pull request Apr 2, 2024
@takluyver
Copy link
Member Author

Numpy 2.0 requires Python >= 3.9, whereas we're still testing against 3.8. So for now I've made it conditional: it continues using oldest-supported-numpy to build on Python 3.8.

We can discuss dropping Python 3.8 as a separate question. The NEP 29 recommendation is to drop it later this month, though I tend to err on the cautious side with old Python versions, not least as we're still using 3.8 in some places at XFEL.

@takluyver
Copy link
Member Author

Looks like we've got some issues on Windows, mostly similar to:

>           assert normalized_dset_dtype == normalized_arr_dtype, \
                "Dtype mismatch (%s vs %s)%s" % (normalized_dset_dtype, normalized_dset_dtype, message)
E           AssertionError: Dtype mismatch (int64 vs int64)

@takluyver
Copy link
Member Author

Ah, I see there's a bug in the helper function that makes the message less than helpful.

Copy link

codecov bot commented Apr 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.53%. Comparing base (078a481) to head (e366e49).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2401   +/-   ##
=======================================
  Coverage   89.53%   89.53%           
=======================================
  Files          17       17           
  Lines        2380     2380           
=======================================
  Hits         2131     2131           
  Misses        249      249           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@takluyver
Copy link
Member Author

That seems to be working; I'll merge in another day or so if there are no objections.

@aragilar
Copy link
Member

aragilar commented Apr 3, 2024

Looks good to me, and agree on keeping python 3.8 supported for now.

@tacaswell tacaswell merged commit 066cad1 into h5py:master Apr 3, 2024
41 checks passed
@takluyver takluyver added this to the 3.11 milestone Apr 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants