New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Try building with numpy 2.0 rc1 #2401
Conversation
Numpy 2.0 requires Python >= 3.9, whereas we're still testing against 3.8. So for now I've made it conditional: it continues using We can discuss dropping Python 3.8 as a separate question. The NEP 29 recommendation is to drop it later this month, though I tend to err on the cautious side with old Python versions, not least as we're still using 3.8 in some places at XFEL. |
Looks like we've got some issues on Windows, mostly similar to:
|
Ah, I see there's a bug in the helper function that makes the message less than helpful. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2401 +/- ##
=======================================
Coverage 89.53% 89.53%
=======================================
Files 17 17
Lines 2380 2380
=======================================
Hits 2131 2131
Misses 249 249 ☔ View full report in Codecov by Sentry. |
That seems to be working; I'll merge in another day or so if there are no objections. |
Looks good to me, and agree on keeping python 3.8 supported for now. |
See discussion on #2353.