Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ppc64le longdouble type conversion #842

Merged
merged 1 commit into from
Aug 27, 2017
Merged

Conversation

mraspaud
Copy link
Contributor

This PR fixes the conversion to longdouble. The problem lies in the erroneous bit-size of the components by hdf5, hence requiring some hardcoding for longdoubles (double double implementation in this case).

Signed-off-by: Martin Raspaud martin.raspaud@smhi.se

Signed-off-by: Martin Raspaud <martin.raspaud@smhi.se>
@tacaswell tacaswell added this to the 2.7 milestone Feb 1, 2017
@tacaswell
Copy link
Member

I could be convinced to leave 2.7 as is (if it is currently passing in the debian builds) and do this in a 2.7.1 or to merge this for 2.7.

@epourmal Can you shed any light on this from the hdf5 group side? Should we send an email the the mailing list?

@mraspaud
Copy link
Contributor Author

mraspaud commented Feb 1, 2017

@tacaswell I would go for the next release, and leave 2.7 as is. Unless @ghisvail has time to test it ?

@aragilar
Copy link
Member

@ghisvail Are you able to test this so we can get this into 2.7.1?

@ghisvail
Copy link
Contributor

I will set some time aside this week to test 2.7 with this fix. Stay tuned.

@tacaswell tacaswell modified the milestones: 2.7.1, 2.7 Mar 30, 2017
@ghisvail
Copy link
Contributor

ghisvail commented Apr 8, 2017

2.7.0 is out on Debian. Most architectures built successfully, besides powerpc

@tacaswell
Copy link
Member

@mraspaud @ghisvail What is the state of this?

@ghisvail
Copy link
Contributor

@tacaswell Just make a release and we'll iterate on the feedback from the builders. I have got no time to do further testing.

@mraspaud
Copy link
Contributor Author

It was tested by hand on the concerned architectures, so I'm pretty confident it should be safe to merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants