Merge pull request #186 from ha-pu/cran_update

Cran update to 0.0.14
ha-pu · Mar 6, 2023 · 726f24e · 726f24e
2 parents 90cf63d + 894c164
commit 726f24e
Show file tree

Hide file tree

Showing 8 changed files with 108 additions and 7 deletions.
diff --git a/CRAN-SUBMISSION b/CRAN-SUBMISSION
@@ -1,3 +1,3 @@
-Version: 0.0.13
-Date: 2023-02-23 16:31:02 UTC
-SHA: 6842156ba6819d072c8abb0d3bae2d3ecd2381a4
+Version: 0.0.14
+Date: 2023-03-06 18:32:07 UTC
+SHA: ba8e0635c56b8f96a3a67a8253f66eae441d3723
diff --git a/DESCRIPTION b/DESCRIPTION
@@ -1,7 +1,7 @@
 Type: Package
 Package: globaltrends
 Title: Download and Measure Global Trends Through Google Search Volumes
-Version: 0.0.13.9000
+Version: 0.0.14
 Authors@R: c(
     person("Harald", "Puhr", , "harald.puhr@gmail.com", role = c("aut", "cre")),
     person("Jakob", "Muellner", role = "ccp")

diff --git a/NEWS.md b/NEWS.md
@@ -1,4 +1,4 @@
-# globaltrends 0.0.13.9000
+# globaltrends 0.0.14
 
 * Remove dependency on `glue` package, calls of `glue::glue` are replaced with `paste` and `paste0`
 * Remove dependency on `ineq` package, calls of `ineq::ineq` are replaced with internal functions

diff --git a/cran-comments.md b/cran-comments.md
@@ -1,3 +1,94 @@
+# Resubmission 0.0.14
+
+## Test environments
+* local Windows 10 Enterprise, 64 bit (R 4.2.2)
+* Windows Server 2022, R-devel, 64 bit on R-Hub
+* Ubuntu Linux 20.04.1 LTS, R-release, GCC on R-Hub
+* Fedora Linux, R-devel, clang, gfortran on R-Hub
+* macOS-latest (release) on GitHub
+* windows-latest (release) on GitHub
+* ubuntu-latest (devel) on GitHub
+* ubuntu-latest (release) on GitHub
+* ubuntu-latest (oldrel-1) on GitHub
+* Windows Server 2022, R 2023-03-05 r83940 ucrt (devel) on winbuilder
+* Windows Server 2022, R 4.2.2 (release) on winbuilder
+* Windows Server 2008, R 4.1.3 (oldrelease) on winbuilder
+
+## Test coverage
+The test coverage [devtools::test_coverage()] of the package is 96%.
+
+## Reverse dependencies
+Results from [revdepcheck::revdep_check()]:
+
+```
+We checked 0 reverse dependencies, comparing R CMD check results across CRAN and
+dev versions of this package.
+
+ * We saw 0 new problems
+ * We failed to check 0 packages
+```
+
+## R CMD check results
+There were no ERRORs or WARNINGs. 
+
+### Note 1
+There is one NOTE that is only found on Windows (Server 2022, R-devel 64-bit):
+
+```
+* checking for detritus in the temp directory ... NOTE
+Found the following files/directories:
+  'lastMiKTeXException'
+```
+
+As noted in [R-hub issue #503](https://github.com/r-hub/rhub/issues/503), this
+could be due to a bug/crash in MiKTeX and can likely be ignored. The same note
+was reported in the initial submission.
+
+### Note 2
+There is one NOTE that is only found on Fedora Linux (R-devel, clang, gfortran):
+
+```
+* checking HTML version of manual ... NOTE
+  Skipping checking HTML validation: no command 'tidy' found
+```
+
+As noted in [R-hub issue #548](https://github.com/r-hub/rhub/issues/548), this
+issue appears to be independent of the configuration on the local machine.
+
+## winbuilder
+Winbuilder might show a note regarding (possible) invalid URLs:
+
+```
+URL: https://trends.google.com/trends/explore?q=%2Fm%2F03phgz&geo=AT
+  From: inst/doc/globaltrends.html
+  Status: 429
+  Message: Too Many Requests
+```
+
+This does not signify an invalid URL but indicates that Google Trends blocks
+downloads due to too many requests.  The same note was reported in the initial
+submission.
+
+---
+
+In this resubmission of the globaltrends package I have made the following updates:
+
+* Remove dependency on `glue` package
+* Remove dependency on `ineq` package
+* Use functions `dbCreateTable` and `dbAppendTable` from `DBI 1.1.0`
+* Remove the function `plot_map` from the package and point users to more flexibile alternatives
+* Remove dependency on the `maps` package
+* Remove reference to non-existent table `data_global` in function `remove_data`
+* Adapt test *remove_data6* in `test-computations.R` to avoid check failures on R-oldrease
+
+The adaption of test *remove_data6* in `test-computations.R` will also resolve the
+failed CRAN checks for the current version of the package (0.0.13). This is because
+the test failure does not signify unintended behavior of the package. Instead it
+points to unintended behavior in the test. This issue is now resolved.
+
+Thanks!
+Harald Puhr
+
 # Resubmission 0.0.13
 
 ## Test environments

diff --git a/dev/submission_checks.rmd b/dev/submission_checks.rmd
@@ -65,6 +65,16 @@ revdepcheck::revdep_check(pkg = "..")
 devtools::check_win_devel()
 ```
 
+* devtools::check_win_release()
+```{r}
+devtools::check_win_release()
+```
+
+* devtools::check_win_oldrelease()
+```{r}
+devtools::check_win_oldrelease()
+```
+
 * devtools::check_rhub()
 ```{r}
 devtools::check_rhub(pkg = "..", email = "harald.puhr@gmail.com")

diff --git a/globaltrends_Vignette.pdf b/globaltrends_Vignette.pdf
diff --git a/vignettes/globaltrends.Rmd b/vignettes/globaltrends.Rmd
@@ -32,7 +32,7 @@ library(globaltrends)
 
 # package version --------------------------------------------------------------
 packageVersion("globaltrends")
-#> [1] '0.0.13'
+#> [1] '0.0.14'
 ```
 
 # Google Trends

diff --git a/vignettes/globaltrends.html b/vignettes/globaltrends.html
@@ -358,7 +358,7 @@ <h4 class="author">Harald Puhr</h4>
 <span id="cb1-9"><a href="#cb1-9" aria-hidden="true" tabindex="-1"></a></span>
 <span id="cb1-10"><a href="#cb1-10" aria-hidden="true" tabindex="-1"></a><span class="co"># package version --------------------------------------------------------------</span></span>
 <span id="cb1-11"><a href="#cb1-11" aria-hidden="true" tabindex="-1"></a><span class="fu">packageVersion</span>(<span class="st">&quot;globaltrends&quot;</span>)</span>
-<span id="cb1-12"><a href="#cb1-12" aria-hidden="true" tabindex="-1"></a><span class="co">#&gt; [1] &#39;0.0.13&#39;</span></span></code></pre></div>
+<span id="cb1-12"><a href="#cb1-12" aria-hidden="true" tabindex="-1"></a><span class="co">#&gt; [1] &#39;0.0.14&#39;</span></span></code></pre></div>
 <div id="google-trends" class="section level1">
 <h1>Google Trends</h1>
 <p>Google offers public access to global search volumes from its search