Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V0.8 go r59 #10

Closed
wants to merge 2 commits into from
Closed

V0.8 go r59 #10

wants to merge 2 commits into from

Conversation

kesselborn
Copy link

this makes doozer compile with go r59. Two types of problems occured to me:

1.) some function signatures changed
2.) the provided generated protobuffer files did not work for me, i.e. I removed *.pb.go files from the repository and added them to be removed when clean is called -- they get auto generated when all.sh is executed.

@dgrijalva
Copy link
Contributor

It's actually useful to have the protobuf files checked in. If they're not, anyone who wants to build doozerd has to do install a bunch of additional requirements to have these files regenerated.

@kesselborn
Copy link
Author

I see the usefulness, but it's quite annoying if the checked in headers do not work -- which happened for me.

@jsx7ba
Copy link

jsx7ba commented Sep 6, 2011

I've hit the same problem with protocol buffers while trying to create a python doozer client. I would imagine that if someone had protocol buffers installed before installing fraggle, they'd hit this problem too. There's no documentation to indicate which protocol buffer version to use.

@bmizerany
Copy link
Contributor

fixed awhile ago.

@bmizerany bmizerany closed this Jan 31, 2012
zyxar pushed a commit to zyxar/doozerd that referenced this pull request Aug 27, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants