Use document buffer #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
An ITextView can have multiple ITextBuffer instances associated with it. When looking for the main ITextDocument associated with an ITextView it should always be done through the DocumentBuffer. The previous code was using ITextView::TextBuffer which is equivalent to the EditBuffer. The reason this worked in standard files (like a .cs) is that the EditBuffer and DocumentBuffer are the same value. In razor files the view is much more complex and the EditBuffer is actually a rather complicated projection buffer (instance of IProjectionBuffer). Hence it had no associated document. closes #21
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An ITextView can have multiple ITextBuffer instances associated with it.
When looking for the main ITextDocument associated with an ITextView it
should always be done through the DocumentBuffer. The previous code was
using ITextView::TextBuffer which is equivalent to the EditBuffer.
The reason this worked in standard files (like a .cs) is that the
EditBuffer and DocumentBuffer are the same value. In razor files the
view is much more complex and the EditBuffer is actually a rather
complicated projection buffer (instance of IProjectionBuffer). Hence it
had no associated document.
closes #21