-
-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
link failure when building mpv against libplacebo git master #198
Comments
cc @kasper93 |
Meson should detect needed linking language, but probably need a wipe, because it generally has trouble with invalidating its cache when needed. |
I use mpv-build to compile. Did the clean script before compiling, still failed. |
I see.
I get wall of spirv-tools errors, which is exactly the same case.
I will see how to workaround this Nothing to change on libplacebo side. EDIT: Ok, nevermind meson. This is fully mpv-build issues adding random flags when it shouldn't touch it. |
And actually it is already reported mpv-player/mpv-build#215 |
This is required when linking ffmpeg statically and generally good practice to have on shared libraries anyway. Prerequisit for fixes in mpv-build for: mpv-player/mpv-build#215 haasn/libplacebo#198
This is required when linking ffmpeg statically and generally good practice to have on shared libraries anyway. Prerequisit for fixes in mpv-build for: mpv-player/mpv-build#215 haasn/libplacebo#198
It shouldn't be added unconditionally and with all the fragile checks if it is supported it is way better to handle it in the meson istself. See also: mpv-player/mpv#12346 Fixes: mpv-player#215 haasn/libplacebo#198
It shouldn't be added unconditionally and with all the fragile checks if it is supported it is way better to handle it in the meson itself. See also: mpv-player/mpv#12346 Fixes: mpv-player#215 haasn/libplacebo#198
Will be fixed by: |
I apply your modifications to mpv and mpv-build. It indeed solves the compile issue. |
This is required when linking ffmpeg statically and generally good practice to have on shared libraries anyway. Prerequisit for fixes in mpv-build for: mpv-player/mpv-build#215 haasn/libplacebo#198
It shouldn't be added unconditionally and with all the fragile checks if it is supported it is way better to handle it in the meson itself. See also: mpv-player/mpv#12346 Fixes: #215 haasn/libplacebo#198
This is required when linking ffmpeg statically and generally good practice to have on shared libraries anyway. Prerequisit for fixes in mpv-build for: mpv-player/mpv-build#215 haasn/libplacebo#198
link failure when building mpv against libplacebo git master
clang-16
gcc-12
A known good version is d6f1db1 on Sep 3.
The text was updated successfully, but these errors were encountered: