meson: add -Bsymbolic for libmpv #12346
Conversation
This is required when linking ffmpeg statically and generally good practice to have on shared libraries anyway. Prerequisit for fixes in mpv-build for: mpv-player/mpv-build#215 haasn/libplacebo#198
It shouldn't be added unconditionally and with all the fragile checks if it is supported it is way better to handle it in the meson istself. See also: mpv-player/mpv#12346 Fixes: mpv-player#215 haasn/libplacebo#198
It shouldn't be added unconditionally and with all the fragile checks if it is supported it is way better to handle it in the meson itself. See also: mpv-player/mpv#12346 Fixes: mpv-player#215 haasn/libplacebo#198
Is it? I don't pretend to know the details of all this linking stuff, but I thought you weren't actually supposed to use this flag in general. |
It is whole story of ELF weirdness and why symbol interposition is not really that good idea. tl;dr; This flag sets You can read more what it does here: All in all, it doesn't mean much for libmpv. But those two patches fixes compilation when statically linking ffmpeg. I frankly don't know why it fails when it is added when linking executable, but well let's not add it in this case. If only people wouldn't link statically everything... just use shared libraries. |
|
Sorry for the delay. This still feels kind of like a sledgehammer, but ffmpeg does mention this flag in their documentation so whatever I guess. |
It shouldn't be added unconditionally and with all the fragile checks if it is supported it is way better to handle it in the meson itself. See also: mpv-player/mpv#12346 Fixes: #215 haasn/libplacebo#198
This is required when linking ffmpeg statically and generally good practice to have on shared libraries anyway.
Prerequisit for fixes in mpv-build for:
mpv-player/mpv-build#215
haasn/libplacebo#198