Add ability for worker to bind to local docker socket for testing exports #112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elliott-davis
requested review from
chefsalim,
raskchanky and
reset
as code owners
|
Thanks for the pull request! Here is what will happen next:
Thank you for contributing! |
elliott-davis
force-pushed
the
elliott/local_worker
branch
from
034c594
to
e01ad2c
Compare
elliott-davis
force-pushed
the
elliott/local_worker
branch
from
e01ad2c
to
4be999c
Compare
elliott-davis
changed the title
elliott-davis
force-pushed
the
elliott/local_worker
branch
from
4be999c
to
40fe5bd
Compare
chefsalim
reviewed
Feb 5, 2018
| @@ -145,7 +145,12 @@ impl<'a> DockerExporter<'a> { | |||
| ); | |||
| cmd.env(DOCKER_HOST_ENVVAR, sock); // Use the job-specific `dockerd` | |||
| cmd.stdout(Stdio::piped()); | |||
| cmd.stderr(Stdio::piped()); | |||
| match env::var_os(DEV_MODE) { | |||
| Some(_) => debug!("Not exporting in dev mode"), | |||
There was a problem hiding this comment.
Sneaky :) Maybe put in a comment that this part is a workaround for now until we solve the streaming log problem correctly?
chefsalim
reviewed
Feb 5, 2018
| @@ -104,7 +104,12 @@ impl<'a> Studio<'a> { | |||
| } | |||
| } | |||
| cmd.stdout(Stdio::piped()); | |||
| cmd.stderr(Stdio::piped()); | |||
| match env::var_os(DEV_MODE) { | |||
| Some(_) => debug!("Studio not displaying stderr"), | |||
elliott-davis
force-pushed
the
elliott/local_worker
branch
from
40fe5bd
to
6ce40d8
Compare
chefsalim
reviewed
Feb 6, 2018
| @@ -97,43 +97,46 @@ impl<'a> Studio<'a> { | |||
| cmd.env("PATH", env::var("PATH").unwrap_or(String::from(""))); // Sets `$PATH` | |||
| cmd.env(NONINTERACTIVE_ENVVAR, "true"); // Disables progress bars | |||
| cmd.env("TERM", "xterm-256color"); // Emits ANSI color codes | |||
| // propagate debugging environment variables into Airlock and Studio | |||
| // propagate debugging environment variables into Airlock and Studio | |||
There was a problem hiding this comment.
Is the spacing intentional?
There was a problem hiding this comment.
rustfmt did that
chefsalim
approved these changes
Feb 6, 2018
…orts Signed-off-by: Travis Elliott Davis <edavis@chef.io>
elliott-davis
force-pushed
the
elliott/local_worker
branch
from
6ce40d8
to
177202e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #117
Signed-off-by: Travis Elliott Davis edavis@chef.io