Cleanup errors and add body to error response #792
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elliott-davis
requested review from
chefsalim,
eeyun,
raskchanky and
reset
as code owners
|
Thanks for the pull request! Here is what will happen next:
Thank you for contributing! |
chefsalim
reviewed
Nov 9, 2018
| @@ -193,7 +193,9 @@ impl Into<HttpResponse> for Error { | |||
| Error::ParseIntError(_) => HttpResponse::new(StatusCode::BAD_REQUEST), | |||
| Error::Protocol(_) => HttpResponse::new(StatusCode::INTERNAL_SERVER_ERROR), | |||
| Error::BuilderCore(ref e) => HttpResponse::new(bldr_core_err_to_http(e)), | |||
| Error::DieselError(ref e) => HttpResponse::new(diesel_err_to_http(e)), | |||
| Error::DieselError(ref e) => { | |||
| HttpResponse::with_body(diesel_err_to_http(e), e.description().to_string()) | |||
There was a problem hiding this comment.
I'm not sure about exposing the description in the error - the changes we've made so far explicitly don't put error text in the body any longer.
There was a problem hiding this comment.
I'm okay with taking it out but we need some sort of debugging around these errors. Would adding a debug line in each error block be okay?
There was a problem hiding this comment.
Yes we can add debug lines
eeyun
approved these changes
Nov 9, 2018
added 2 commits
November 9, 2018 11:17
Signed-off-by: Elliott Davis <elliott@excellent.io>
Signed-off-by: Elliott Davis <elliott@excellent.io>
elliott-davis
force-pushed
the
elliott/error_cleanup
branch
from
866f691
to
c4c651c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Elliott Davis elliott@excellent.io