Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[scaffolding-chef] Add initial chef-client run with no splay or interval #1728

Merged
merged 2 commits into from
Jul 25, 2018

Conversation

jonlives
Copy link
Contributor

By default, the chef scaffolding will wait for cfg.interval seconds before performing the initial chef-client run in the run hook. This change makes it perform an initial chef-client run without waiting, and then hand over to the chef-client with interval and splay configured going forwards.

Signed-off-by: Jon Cowie jonlives@gmail.com

Signed-off-by: Jon Cowie <jonlives@gmail.com>
@jonlives jonlives requested a review from a team as a code owner July 25, 2018 12:22
@thesentinels
Copy link
Contributor

Thanks for the pull request! Here is what will happen next:

  1. Your PR will be reviewed by the maintainers
  2. If everything looks good, one of them will approve it, and your PR will be merged.

Thank you for contributing!

Copy link
Contributor

@elliott-davis elliott-davis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should these be two separate exec calls for clarity?

Signed-off-by: Jon Cowie <jonlives@gmail.com>
@jonlives
Copy link
Contributor Author

@elliott-davis good call - I've tested that out and it works just the same, so have pushed that change

Copy link
Contributor

@elliott-davis elliott-davis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@smacfarlane smacfarlane merged commit 48b2d99 into habitat-sh:master Jul 25, 2018
@predominant predominant changed the title Add initial chef-client run with no splay or interval [scaffolding-chef] Add initial chef-client run with no splay or interval Jul 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants