Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove eventsrv #5962

Closed
2 tasks done
christophermaier opened this issue Dec 10, 2018 · 3 comments · Fixed by #6069
Closed
2 tasks done

Remove eventsrv #5962

christophermaier opened this issue Dec 10, 2018 · 3 comments · Fixed by #6069
Labels
Epic Focus:Supervisor Related to the Habitat Supervisor (core/hab-sup) component Type: Chore Issues for general code and infrastructure maintenance
Milestone
Post 1.0

Comments

@christophermaier
Copy link
Contributor

christophermaier commented Dec 10, 2018 •
edited by raskchanky

Description

It's essentially prototype code that hasn't been touched or used in a long time. Were we to revive the feature, I'm pretty sure we'd want to look at it fresh, rather than using the existing code. I'm pretty sure the build process is broken (and has been for a while), and isn't part of our release process.

If we removed it, we could simplify the Supervisor, and we would also make #5949 easier to implement.

Acceptance Criteria

  • All source code to eventsrv is removed form Supervisor
  • Add renamed_and_removed_lints to clippy's DENIED_LINTS in Makefile.
@christophermaier christophermaier added this to the 1.0 Supervisor milestone Dec 10, 2018
@christophermaier christophermaier mentioned this issue Dec 10, 2018
Closed
@baumanj
Copy link
Contributor

baumanj commented Dec 11, 2018

Yes, please!

@dmccown
Copy link

dmccown commented Dec 14, 2018

There's a command line flag that eventsrv responds to that should be deprecated as well.

@baumanj
Copy link
Contributor

baumanj commented Dec 14, 2018

Deprecated implies is still works, but generates a warning; I think we should be removing this code entirely. I'd be open to the idea of a (possibly hidden) CLI option that reports that the feature has been removed, but since I really don't think anyone is using it, just deleting it seems like the most appropriate course to me.

@dmccown dmccown added the Epic label Dec 21, 2018
@dmccown dmccown modified the milestones: 1.0 Supervisor, Post 1.0 Dec 21, 2018
baumanj added a commit that referenced this issue Jan 7, 2019
@baumanj
Fix breakage introduced by automatic conversion to rust 2018 idioms
a12523e 
- Import locked_env_var in the new style and remove unnecessary macro_use
- Add back "extern crate time as time_crate" since the new explicit form:
  "use ::time" gets reverted to the ambiguous "use time" by rustfmt
- Change "use json" to "use crate::json" to resolve ambiguity with macro

The change to eventsrv-protocol/src/message/event.rs is generated code which
reverts some changes the automatic conversion added. It's built with
protobuf rather than prost, so it's not worth fixing since we'll be removing
the EventSrv code soon anyway.
See #5962

Signed-off-by: Jon Bauman <5906042+baumanj@users.noreply.github.com>
@baumanj baumanj mentioned this issue Jan 17, 2019
Merged
@christophermaier christophermaier added Focus:Supervisor Related to the Habitat Supervisor (core/hab-sup) component Type: Chore Issues for general code and infrastructure maintenance and removed A-supervisor labels Jul 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Epic Focus:Supervisor Related to the Habitat Supervisor (core/hab-sup) component Type: Chore Issues for general code and infrastructure maintenance
Projects
None yet
Milestone
Post 1.0
Development

Successfully merging a pull request may close this issue.

Remove eventsrv. habitat-sh/habitat
3 participants
@christophermaier @dmccown @baumanj