Remove eventsrv. #6069
Merged
Remove eventsrv. #6069
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raskchanky
requested review from
baumanj,
chefsalim,
christophermaier,
eeyun,
fnichol,
jamesc and
reset
as code owners
|
Thanks for the pull request! Here is what will happen next:
Thank you for contributing! |
|
@baumanj Yeah I think it does. I'll review those issues and make the appropriate adjustments here. |
|
Additional lines that can be modified/removed:
|
baumanj
approved these changes
Jan 17, 2019
There was a problem hiding this comment.
Once the things in
#6069 (comment) are addressed, I'm 👍
Those are straightforward, so I'll approve now.
raskchanky
force-pushed
the
jb/remove-eventsrv
branch
from
9331d63
to
d2e9219
Compare
Eventsrv has grown old and crufty and we're not actually using it in any meaningful fashion. We're going to remove it for now and revisit it at a later date. Signed-off-by: Josh Black <raskchanky@gmail.com>
raskchanky
force-pushed
the
jb/remove-eventsrv
branch
from
d2e9219
to
33d24e6
Compare
|
Appveyor has failed twice in a row due to timeouts. Travis is passing. I'm going to merge this. |
chef-ci
added a commit
that referenced
this pull request
Jan 18, 2019
Obvious fix; these changes are the result of automation not creative thinking.
christophermaier
added
Type:Breaking Change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Eventsrv has grown old and crufty and we're not actually using it in any meaningful fashion. We're going to remove it for now and revisit it at a later date.
Resolves #5962
Resolves #6012
Signed-off-by: Josh Black raskchanky@gmail.com