Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Authenticated middleware self contained #1217

Merged
merged 1 commit into from Sep 8, 2016
Merged

Make Authenticated middleware self contained #1217

merged 1 commit into from Sep 8, 2016

Conversation

reset
Copy link
Collaborator

@reset reset commented Sep 7, 2016 •
edited by fnichol

  • Authenticated middleware made less brittle by falling
    back to initializing a new BrokerConn if the RouteBroker middleware
    does not appear in the middleware chain before the Authenticated
    middleware.
  • Authenticated middleware now owns it's own copy of GitHubClient

Signed-off-by: Jamie Winsor jamie@vialstudios.com

@reset
Make Authenticated middleware self contained
b4036a6 
* Authenticated middleware made less brittle by falling
  back to initializing a new BrokerConn if the RouteBroker middleware
  does not appear in the middleware chain before the Authenticated
  middleware.
* Authenticated middleware now owns it's own copy of GitHubClient

Signed-off-by: Jamie Winsor <jamie@vialstudios.com>
@thesentinels
Copy link
Contributor

@reset, thanks for your PR! By analyzing the annotation information on this pull request, we identified @metadave, @adamhjk, @smith, @fnichol and @lamont-granquist to be potential reviewers

@reset
Copy link
Collaborator Author

reset commented Sep 8, 2016

I'm going to merge this one in as it contains a major bug fix for an issue with uploading packages that was introduced in the refactors from #1210. If anyone wants to chat about it just message me and we can go over the changes!

@reset reset merged commit 99c992a into master Sep 8, 2016
@reset reset removed the In Progress label Sep 8, 2016
@reset reset deleted the middleware-fix branch September 8, 2016 18:56
@fnichol fnichol added the Chore label Sep 14, 2016
@eeyun eeyun added C-chore and removed Chore labels Jun 6, 2017
@christophermaier christophermaier added Type: Chore Issues for general code and infrastructure maintenance and removed C-chore labels Jul 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Type: Chore Issues for general code and infrastructure maintenance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@reset @thesentinels @christophermaier @fnichol @eeyun