Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use bodyparser::Struct to parse request bodies in HTTP Gateways #1227

Merged
merged 1 commit into from Sep 14, 2016
Merged

Use bodyparser::Struct to parse request bodies in HTTP Gateways #1227

merged 1 commit into from Sep 14, 2016

Conversation

reset
Copy link
Collaborator

@reset reset commented Sep 14, 2016

A refactoring to simplify input validation and parsing on all
HTTP Gateways by leveraging serde/serde_json and bodyparser::Struct
instead of handling raw JSON with bodyparser::Json.

gif-keyboard-12425227071449985829

@reset
Use bodyparser::Struct to parse request bodies in HTTP Gateways
5949e11 
A refactoring to simplify input validation and parsing on all
HTTP Gateways by leveraging serde/serde_json and `bodyparser::Struct`
instead of handling raw JSON with `bodyparser::Json`.

Signed-off-by: Jamie Winsor <jamie@vialstudios.com>
@thesentinels
Copy link
Contributor

@reset, thanks for your PR! By analyzing the annotation information on this pull request, we identified @metadave, @adamhjk, @fnichol, @smith and @lamont-granquist to be potential reviewers

@bookshelfdave
Copy link
Contributor

gif-keyboard-1218538865522889762

@reset reset merged commit f09cedf into master Sep 14, 2016
@reset reset deleted the cuts-body-parsing branch September 14, 2016 18:22
@reset reset removed the In Progress label Sep 14, 2016
@fnichol fnichol added the Chore label Sep 14, 2016
@eeyun eeyun added C-chore and removed Chore labels Jun 6, 2017
@christophermaier christophermaier added Type: Chore Issues for general code and infrastructure maintenance and removed C-chore labels Jul 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Type: Chore Issues for general code and infrastructure maintenance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@reset @thesentinels @bookshelfdave @christophermaier @fnichol @eeyun