Default binlink to all bins in package #2007
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #1921 This change makes the BINARY argument to the binlink command optional. If omitted, all binaries in the package will be symlinked. ``` ../../target/debug/hab pkg binlink -d /usr/local/bin core/net-tools » Symlinking dnsdomainname from core/net-tools into /usr/local/bin ★ Binary dnsdomainname from core/net-tools/1.60/20161214060044 symlinked to /usr/local/bin/dnsdomainname » Symlinking ypdomainname from core/net-tools into /usr/local/bin ★ Binary ypdomainname from core/net-tools/1.60/20161214060044 symlinked to /usr/local/bin/ypdomainname » Symlinking domainname from core/net-tools into /usr/local/bin ★ Binary domainname from core/net-tools/1.60/20161214060044 symlinked to /usr/local/bin/domainname » Symlinking hostname from core/net-tools into /usr/local/bin ★ Binary hostname from core/net-tools/1.60/20161214060044 symlinked to /usr/local/bin/hostname » Symlinking netstat from core/net-tools into /usr/local/bin ★ Binary netstat from core/net-tools/1.60/20161214060044 symlinked to /usr/local/bin/netstat ``` Signed-off-by: Nolan Davidson <ndavidson@chef.io>
mwrock
approved these changes
Mar 28, 2017
|
This is great! |
|
Note that the travis failure in not pertinent to this pr. |
|
@thesentinels approve |
|
🤘 I am testing your branch against master before merging it. We do this to ensure that the master branch is never failing tests. |
|
|
Travis CI has
1 similar comment
|
|
|
💖 Travis CI reports this PR passed. It always makes me feel nice when humans approve of one anothers work. I'm merging this PR now. I just want you and the contributor to answer me one question:
|
christophermaier
added
Focus: CLI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1921
This change makes the BINARY argument to the binlink command optional.
If omitted, all binaries in the package will be symlinked.
Signed-off-by: Nolan Davidson ndavidson@chef.io