Explicitly binlink bash and sh to /bin in exported images #2993
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There appears to be some leaking over of the `HAB_BINLINK_DIR` environment variable set in the default studio setup script that causes `/bin/sh` to not exist in Docker containers exported by version 0.30.1. While more work will need to be done to properly insulate things, explicitly overriding the link destination will get these working now, unblocking the various people that have encountered this bug. Fixes #2989 Signed-off-by: Christopher Maier <cmaier@chef.io>
|
Thanks for the pull request! Here is what will happen next:
Thank you for contributing! |
|
|
christophermaier
added
Focus: Studio
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There appears to be some leaking over of the
HAB_BINLINK_DIRenvironment variable set in the default studio setup script that
causes
/bin/shto not exist in Docker containers exported by version0.30.1.
While more work will need to be done to properly insulate things,
explicitly overriding the link destination will get these working now,
unblocking the various people that have encountered this bug.
Fixes #2989
Signed-off-by: Christopher Maier cmaier@chef.io