Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move origin page to a feature module with its own routing #3047

Merged
merged 1 commit into from
Sep 1, 2017
Merged

Move origin page to a feature module with its own routing #3047

merged 1 commit into from
Sep 1, 2017

Conversation

elliott-davis
Copy link
Contributor

tenor-9594429

@thesentinels
Copy link
Contributor

Thanks for the pull request! Here is what will happen next:

  1. Your PR will be reviewed by the maintainers
  2. If everything looks good, one of them will approve it, and your PR will be merged.

Thank you for contributing!

@elliott-davis elliott-davis force-pushed the elliott/prep-for-settings-tab branch 4 times, most recently from 3e64377 to 636f6f1 Compare August 31, 2017 20:51
Move origin page to a feature module with its own routing
0c9a958 
Signed-off-by: Elliott Davis <edavis@chef.io>
mgamini
mgamini approved these changes Aug 31, 2017
View reviewed changes
Copy link
Contributor

@mgamini mgamini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cnunciato
cnunciato approved these changes Aug 31, 2017
View reviewed changes
Copy link
Contributor

@cnunciato cnunciato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The mocks suggest we should link origin packages to /:origin/:name/latest, so it'd be good to doublecheck that and tweak if necessary, but otherwise:

@elliott-davis
Copy link
Contributor Author

@thesentinels approve

@thesentinels
Copy link
Contributor

Hey, @elliott-davis - you don't have permission to issue approve on this pull request.

Nope

@cnunciato
Copy link
Contributor

@thesentinels approve

@thesentinels
Copy link
Contributor

🤘 I am testing your branch against master before merging it. We do this to ensure that the master branch is never failing tests.

@thesentinels
Copy link
Contributor

:neckbeard: Travis CI has started testing this PR.

@thesentinels
Copy link
Contributor

💖 Travis CI reports this PR passed.

It always makes me feel nice when humans approve of one anothers work. I'm merging this PR now.

I just want you and the contributor to answer me one question:

gif-keyboard-3280869874741411265

@thesentinels thesentinels merged commit b400810 into master Sep 1, 2017
@thesentinels thesentinels deleted the elliott/prep-for-settings-tab branch September 1, 2017 13:45
@christophermaier christophermaier added Type: Feature Issues that describe a new desired feature and removed C-feature labels Jul 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgamini mgamini mgamini approved these changes

@cnunciato cnunciato cnunciato approved these changes

@chefsalim chefsalim Awaiting requested review from chefsalim

@raskchanky raskchanky Awaiting requested review from raskchanky

@reset reset Awaiting requested review from reset

Assignees
No one assigned
Labels
Type: Feature Issues that describe a new desired feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@elliott-davis @thesentinels @cnunciato @mgamini @christophermaier