New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
serialize non-table keys of config before table keys #3059
Conversation
Signed-off-by: Matt Wrock <matt@mattwrock.com>
Thanks for the pull request! Here is what will happen next:
Thank you for contributing! |
@mwrock excellent solution! @thesentinels approve |
🤘 I am testing your branch against master before merging it. We do this to ensure that the master branch is never failing tests. |
Travis CI has started testing this PR. |
💔 Travis CI reports this PR failed to pass the test suite. The next step is to examine the job and figure out why. If it is transient, you can try re-triggering the Travis CI Job - if it passes, this PR will be automatically merged. If it is not transient, you should fix the issue and update this pull request, and issue |
@thesentinels approve |
🤘 I am testing your branch against master before merging it. We do this to ensure that the master branch is never failing tests. |
@thesentinels approve |
🤘 I am testing your branch against master before merging it. We do this to ensure that the master branch is never failing tests. |
Travis CI has started testing this PR. |
💖 Travis CI reports this PR passed. It always makes me feel nice when humans approve of one anothers work. I'm merging this PR now. I just want you and the contributor to answer me one question: |
3rd time's a charm i guess |
When serializing a
Cfg
, its default, environment, user and gossip tables are merged into a newtoml::value::Table
which orders its keys. This means that if there are table keys ordered before non table keys, aValueAfterTable
error occurs.This PR orders the serialization of non table, array and table keys in that order to avoid this error.
Signed-off-by: Matt Wrock matt@mattwrock.com