Add registry type and url to worker payload for ECR dispatching #3967
Conversation
|
Thanks for the pull request! Here is what will happen next:
Thank you for contributing! |
|
I have no way of testing this locally until we get the workers fixed up in local dev |
| }; | ||
| let custom_tag = get_optional_args(&opts, String::from("custom_tag")); | ||
| let registry_url = get_optional_args(&creds, String::from("registry_url")); | ||
| let registry_type = get_optional_args(&opts, String::from("integration")); |
There was a problem hiding this comment.
I'm not sure if this needs to come from opts or creds. You're welcome future me.
| let is_string = format!("{} value is a string", arg); | ||
| match opts.get(arg) { | ||
| Some(key) => { | ||
| let key = key.as_str().expect(&is_string); |
There was a problem hiding this comment.
You might want to return a Result<Option<String>> here if there's a possibility that the given value isn't a string; calling expect will panic.
Alternatively, you might log the error and just return None here.
elliott-davis
force-pushed
the
elliott/ecr_worker
branch
from
289fe04
to
06f73de
Compare
elliott-davis
force-pushed
the
elliott/ecr_worker
branch
2 times, most recently
from
2ac3f50
to
c2387cd
Compare
elliott-davis
force-pushed
the
elliott/ecr_worker
branch
3 times, most recently
from
50797f0
to
c647aee
Compare
elliott-davis
force-pushed
the
elliott/ecr_worker
branch
from
c647aee
to
f0cd587
Compare
Enable ECR exports in the UI Signed-off-by: Travis Elliott Davis <edavis@chef.io>
elliott-davis
force-pushed
the
elliott/ecr_worker
branch
from
f0cd587
to
a06bc49
Compare
|
|
|
@thesentinels approve |
|
🤘 I am testing your branch against master before merging it. We do this to ensure that the master branch is never failing tests. |
|
|
Travis CI has
|
💖 Travis CI reports this PR passed. It always makes me feel nice when humans approve of one anothers work. I'm merging this PR now. I just want you and the contributor to answer me one question:
|
Closes: #3743
Signed-off-by: Travis Elliott Davis edavis@chef.io