Add Kubernetes exporter to build #4200
Conversation
|
Thanks for the pull request! Here is what will happen next:
Thank you for contributing! |
There was a problem hiding this comment.
Will also want to add to https://github.com/habitat-sh/habitat/blob/master/Makefile#L46
.travis.yml
Outdated
| @@ -204,7 +204,7 @@ matrix: | |||
| - os: linux | |||
| env: | |||
| # These components will build as Habitat packages in the provided order | |||
| - COMPONENTS="hab-butterfly hab plan-build backline bintray-publish studio pkg-aci pkg-dockerize pkg-cfize pkg-export-docker pkg-mesosize pkg-tarize sup" | |||
| - COMPONENTS="hab-butterfly hab plan-build backline bintray-publish studio pkg-aci pkg-dockerize pkg-cfize pkg-export-docker pkg-export-kubernetes pkg-mesosize pkg-tarize sup" | |||
There was a problem hiding this comment.
we might want to wait until merging #4202 and add to the exporter job
.travis.yml
Outdated
| @@ -204,7 +204,7 @@ matrix: | |||
| - os: linux | |||
| env: | |||
| # These components will build as Habitat packages in the provided order | |||
| - COMPONENTS="hab-butterfly hab plan-build backline bintray-publish studio pkg-aci pkg-dockerize pkg-cfize pkg-export-docker pkg-mesosize pkg-tarize sup" | |||
| - COMPONENTS="hab-butterfly hab plan-build backline bintray-publish studio pkg-aci pkg-dockerize pkg-cfize pkg-export-docker pkg-export-kubernetes pkg-mesosize pkg-tarize sup" | |||
| - AFFECTED_DIRS="\.bldr\.toml|support/ci/deploy\.sh|Cargo\.toml|Cargo\.lock|VERSION|components/backline|components/bintray-publish|components/pkg-aci|components/pkg-cfize|components/pkg-dockerize|components/pkg-mesosize|components/pkg-tarize|components/plan-build|components/studio|$_RUST_HAB_BIN_COMPONENTS|$_RUST_HAB_LIB_COMPONENTS" | |||
There was a problem hiding this comment.
add the directory here so that changes triger a packageing
There was a problem hiding this comment.
@mwrock I think this is satisfied by adding it to _RUST_HAB_BIN_COMPONENTS
christophermaier
force-pushed
the
cm/add-kubernetes-exporter-to-build
branch
from
b885ea3
to
7b520b3
Compare
christophermaier
force-pushed
the
cm/add-kubernetes-exporter-to-build
branch
from
7b520b3
to
8c09d9d
Compare
`.bldr.toml` paths are based off of current Habitat crate dependencies. Signed-off-by: Christopher Maier <cmaier@chef.io>
christophermaier
force-pushed
the
cm/add-kubernetes-exporter-to-build
branch
from
8c09d9d
to
13ed805
Compare
|
@thesentinels approve |
|
🤘 I am testing your branch against master before merging it. We do this to ensure that the master branch is never failing tests. |
|
|
Travis CI has
|
💖 Travis CI reports this PR passed. It always makes me feel nice when humans approve of one anothers work. I'm merging this PR now. I just want you and the contributor to answer me one question:
|
This ensures that
core/hab-pkg-export-kubernetesis built by both Builder and Travis as needed.Fixes #4199