Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle case where plan file is at the root #4224

Merged
merged 1 commit into from
Dec 7, 2017
Merged

Conversation

chefsalim
Copy link
Contributor

This change fixes a couple of cases where the Builder github hook does not kick off builds as expected when there is no explicit .bldr.toml file:

  1. If the plan.sh is at the root of the repo, or
  2. If the plan.sh is in a habitat subfolder, and the change made is above that folder (eg, in the parent path).

Signed-off-by: Salim Alam salam@chef.io

tenor-114047197

Signed-off-by: Salim Alam <salam@chef.io>
@thesentinels
Copy link
Contributor

Thanks for the pull request! Here is what will happen next:

  1. Your PR will be reviewed by the maintainers
  2. If everything looks good, one of them will approve it, and your PR will be merged.

Thank you for contributing!

@reset
Copy link
Collaborator

reset commented Dec 7, 2017

@thesentinels approve

@thesentinels
Copy link
Contributor

🤘 I am testing your branch against master before merging it. We do this to ensure that the master branch is never failing tests.

@reset
Copy link
Collaborator

reset commented Dec 7, 2017

tenor-160383727

@thesentinels
Copy link
Contributor

:neckbeard: Travis CI has started testing this PR.

@thesentinels
Copy link
Contributor

💖 Travis CI reports this PR passed.

It always makes me feel nice when humans approve of one anothers work. I'm merging this PR now.

I just want you and the contributor to answer me one question:

gif-keyboard-3280869874741411265

@thesentinels thesentinels merged commit e9177b8 into master Dec 7, 2017
@thesentinels thesentinels deleted the SA/fix-github-hook branch December 7, 2017 01:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants