fallback to older powershell binary name if newer one is not installed #4540
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: mwrock <matt@mattwrock.com>
|
Thanks for the pull request! Here is what will happen next:
Thank you for contributing! |
|
I've tested this launcher with the current supervisor and the newer one and verified the fallback works. |
|
Great catch! |
|
@mwrock 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I realized that the newer windows launcher (not yet released) is not backwards compatible with supervisor versions 0.52.0 and under. This fixes that by falling back to the older powershell binary name if the newer one (
pwsh.exe) which is pulled in via supervisors versions 0.53.0 and later does not exist.Signed-off-by: mwrock matt@mattwrock.com