Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

comment pkg_source in init template to prevent build error #4652

Merged
merged 1 commit into from Feb 21, 2018

Conversation

mwrock
Copy link
Contributor

@mwrock mwrock commented Feb 21, 2018

Ideally, you should be able to run build against a freshly initialized plan without error. Currently because pkg_source is set to a dummy URL by default, build will break. This comments that line like we do for other "non buildable" settings.

Signed-off-by: mwrock matt@mattwrock.com

Signed-off-by: mwrock <matt@mattwrock.com>
@thesentinels
Copy link
Contributor

Thanks for the pull request! Here is what will happen next:

  1. Your PR will be reviewed by the maintainers
  2. If everything looks good, one of them will approve it, and your PR will be merged.

Thank you for contributing!

@raskchanky
Copy link
Contributor

@chefsalim
Copy link
Contributor

Seems wierd - did that used to work?

Also just remove the offending line instead of commenting it?

@mwrock
Copy link
Contributor Author

mwrock commented Feb 21, 2018

I don;t think that ever worked. The current tutorials get away with it because they use scaffolding but not the new asp.net one. We do want it commented so that new users see all settings that are available.

@raskchanky raskchanky merged commit f354f5d into master Feb 21, 2018
@raskchanky raskchanky deleted the init_fix branch February 21, 2018 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants