Update Vagrant dev env to 18.04 and cleanup dev steps #5667
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 20, 2018 11:58
Signed-off-by: James Casey <james@chef.io>
Signed-off-by: James Casey <james@chef.io>
jamesc
requested review from
baumanj,
christophermaier,
elliott-davis,
fnichol,
raskchanky and
reset
as code owners
|
Thanks for the pull request! Here is what will happen next:
Thank you for contributing! |
added 2 commits
September 21, 2018 13:50
location and set up for all users This makes the vagrant dev experience a lot better as you get a set up rust environment without having to run your build via sudo Signed-off-by: James Casey <james@chef.io>
This allows for working with the Docker-based BATS tests Signed-off-by: James Casey <james@chef.io>
jamesc
force-pushed
the
jc/dev-env-cleanups
branch
from
5982d00
to
65f0670
Compare
chef-ci
pushed a commit
that referenced
this pull request
Sep 24, 2018
Obvious fix; these changes are the result of automation not creative thinking.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update of vagrant based dev environment so you can build hab as non-root without having to do manual setup sets (like install rust for your user). Also allows to run BATS tests inside Vagrant environment
make batsSigned-off-by: James Casey james@chef.io