Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci] Correct the git sha range if running on Travis. #653

Merged
merged 1 commit into from Jun 4, 2016

Conversation

fnichol
Copy link
Collaborator

@fnichol fnichol commented Jun 4, 2016

See travis-ci/travis-ci#4596 for more details.

gif-keyboard-17546678199012266139

See travis-ci/travis-ci#4596 for more details.

Signed-off-by: Fletcher Nichol <fnichol@nichol.ca>
@thesentinels
Copy link
Contributor

By analyzing the blame information on this pull request, we identified @adamhjk to be a potential reviewer

@fnichol
Copy link
Collaborator Author

fnichol commented Jun 4, 2016

This one is really straight forward and helps to protect mainline, so

gif-keyboard-7199103199990938198

@thesentinels r+

@thesentinels
Copy link
Contributor

📌 Commit 8e4176c has been approved by fnichol

@thesentinels
Copy link
Contributor

⌛ Testing commit 8e4176c with merge 73c5f86...

thesentinels pushed a commit that referenced this pull request Jun 4, 2016
See travis-ci/travis-ci#4596 for more details.

Signed-off-by: Fletcher Nichol <fnichol@nichol.ca>

Pull request: #653
Approved by: fnichol
@thesentinels
Copy link
Contributor

☀️ Test successful - travis

@thesentinels thesentinels merged commit 8e4176c into master Jun 4, 2016
@fnichol fnichol deleted the fnichol/travis-linting-fix branch June 4, 2016 17:22
jtimberman pushed a commit that referenced this pull request Jun 12, 2016
See travis-ci/travis-ci#4596 for more details.

Signed-off-by: Fletcher Nichol <fnichol@nichol.ca>

Pull request: #653
Approved by: fnichol
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants