Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTTP 200 indicates successful response from hab bldr channel delete #7002

Conversation

jeremymv2
Copy link
Contributor

Closes #7001

Previously the hab bldr channel delete operation was requiring a HTTP 201 response to be indicative of success.

This PR changes the success indicator from HTTP 201 to a 200.

Validation with compiled changes:

vagrant@chef-builder:~$ hab bldr channel create --url https://chef-builder.test -o jeremymv2 mychan
Ω Creating channel mychan.
✓ Created channel mychan.
vagrant@chef-builder:~$ hab bldr channel destroy --url https://chef-builder.test -o jeremymv2 mychan
☒ Deleting channel mychan.
✓ Deleted channel mychan.
vagrant@chef-builder:~$

Signed-off-by: Jeremy J. Miller jm@chef.io

…from 201 to 200

Signed-off-by: Jeremy J. Miller <jm@chef.io>
@chef-expeditor
Copy link
Contributor

chef-expeditor bot commented Oct 7, 2019

Hello jeremymv2! Thanks for the pull request!

Here is what will happen next:

  1. Your PR will be reviewed by the maintainers.
  2. If everything looks good, one of them will approve it, and your PR will be merged.

Thank you for contributing!

Copy link
Contributor

@chefsalim chefsalim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure when this regressed, but 200 is the correct response

@raskchanky raskchanky merged commit 5edec1b into habitat-sh:master Oct 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Successful bldr channel delete returns non-zero exit code (but works)
4 participants