Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Always clean up release channels #7130

Merged
merged 1 commit into from Oct 30, 2019

Conversation

@christophermaier
Copy link
Contributor

christophermaier commented Oct 29, 2019

Previously, we deleted release channels at the end of successful
release pipeline runs. However, failed and canceled runs would leave
channels behind. Over time, this can accumulate a lot of extra
channels, which can (with the current implementation of things) slow
down build operations.

Here, we remove this responsibility from the Buildkite pipeline, and
instead allow Expeditor to handle it. This allows us to remove the
offending channel all the time, regardless of what happens in the
pipeline.

Signed-off-by: Christopher Maier cmaier@chef.io

@christophermaier christophermaier self-assigned this Oct 29, 2019
Copy link
Contributor

scotthain left a comment

The only thing to note is this means the scripts will be run on the expeditor machine, not in a pipeline step.

That being said, I think the var name is wrong?

Previously, we deleted release channels at the end of successful
release pipeline runs. However, failed and canceled runs would leave
channels behind. Over time, this can accumulate a lot of extra
channels, which can (with the current implementation of things) slow
down build operations.

Here, we remove this responsibility from the Buildkite pipeline, and
instead allow Expeditor to handle it. This allows us to remove the
offending channel all the time, regardless of what happens in the
pipeline.

Signed-off-by: Christopher Maier <cmaier@chef.io>
@christophermaier christophermaier force-pushed the cm/cleanup-channels branch from e59533e to 23b6370 Oct 30, 2019
@christophermaier christophermaier merged commit d3a04a9 into master Oct 30, 2019
4 of 5 checks passed
4 of 5 checks passed
buildkite/habitat-sh-habitat-master-verify Build #4023 started
Details
DCO This commit has a DCO Signed-off-by
Details
buildkite/habitat-sh-habitat-master-website Build #1103 passed (1 minute, 30 seconds)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
expeditor/config-validation Validated your Expeditor config file
Details
@chef-expeditor chef-expeditor bot deleted the cm/cleanup-channels branch Oct 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.