[CI] Always clean up release channels #7130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scotthain
suggested changes
Oct 29, 2019
Previously, we deleted release channels at the end of successful release pipeline runs. However, failed and canceled runs would leave channels behind. Over time, this can accumulate a lot of extra channels, which can (with the current implementation of things) slow down build operations. Here, we remove this responsibility from the Buildkite pipeline, and instead allow Expeditor to handle it. This allows us to remove the offending channel all the time, regardless of what happens in the pipeline. Signed-off-by: Christopher Maier <cmaier@chef.io>
christophermaier
force-pushed
the
cm/cleanup-channels
branch
from
e59533e
to
23b6370
Compare
scotthain
approved these changes
Oct 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we deleted release channels at the end of successful
release pipeline runs. However, failed and canceled runs would leave
channels behind. Over time, this can accumulate a lot of extra
channels, which can (with the current implementation of things) slow
down build operations.
Here, we remove this responsibility from the Buildkite pipeline, and
instead allow Expeditor to handle it. This allows us to remove the
offending channel all the time, regardless of what happens in the
pipeline.
Signed-off-by: Christopher Maier cmaier@chef.io