Correct some e2e behavior #7564
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add additional saftey check to promotion * Install packages to prevent timeouts * Remove hard-coded channels from tests Signed-off-by: Scott Macfarlane <smacfarlane@chef.io>
smacfarlane
requested review from
christophermaier and
davidMcneil
as code owners
|
Passing run based off of this branch: https://buildkite.com/chef/habitat-sh-habitat-master-end-to-end/builds/513#2d85d1c9-1416-4852-836c-92901e29235d |
mwrock
reviewed
Mar 18, 2020
| @@ -1,5 +1,3 @@ | |||
| $env:HAB_INTERNAL_BLDR_CHANNEL = "dev" | |||
| $env:HAB_BLDR_CHANNEL = "dev" | |||
mwrock
reviewed
Mar 18, 2020
| # These tests will timeout unless the launcher and all of its dependencies | ||
| # are already on disk. | ||
| hab pkg install core/hab-launcher --channel $HAB_BLDR_CHANNEL | ||
|
|
There was a problem hiding this comment.
This is good but it makes me wonder if we should be adding the sup and launcher to the setup_environment.ps1 and .sh e2e scripts.
There was a problem hiding this comment.
I thought about that, but thought it best to avoid installing most components in the shared scripts for now in favor of being explicit about what we expect on the system.
I don't have super strong feelings either way though.
mwrock
approved these changes
Mar 18, 2020
Signed-off-by: Scott Macfarlane <smacfarlane@chef.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses a few issues discovered while attempting to test packages built against the upcoming refresh.
A number of tests will timeout if the dependencies for the packages aren't already on disk. This can occur if the base image
chefes/buildkitedoesn't already have the packages cached. Since these tests aren't specifically testing install logic, it should be safe to pre-install them using the specified $HAB_BLDR_CHANNEL. An alternative approach would be to increase the timeout values, but they'd have to be made arbitrarily large to minimize the risk of timeout.This also disables the promotion step via Buildkite, if the creator isn't Chef Expeditor. This gives us an extra level of safety beyond
maybe_runfrom an accidental promotion.The final change is to remove hard-coded
HAB_BLDR_CHANNELin tests, in favor of letting the environment drive that. This moves us close to being able to run these e2e tests against an arbitrary channel in Builder, which will be useful for validation of pre-release changes.Signed-off-by: Scott Macfarlane smacfarlane@chef.io