Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cats imports fixed #206

Merged
merged 1 commit into from
Apr 11, 2022
Merged

Conversation

alfonsorr
Copy link
Member

Cats imports fixed
Sbt prepared for 2.4 version

Description

Cats for version 2.0.0 works if the imports are correct

Related Issue

#205

Motivation and Context

#184

How Has This Been Tested?

Changed the dependency version all test pass in 2.12 at least

  • This pull request contains appropriate tests?

@alfonsorr alfonsorr added this to the Doric for scala 2.11 milestone Apr 10, 2022
@alfonsorr alfonsorr requested a review from eruizalo April 10, 2022 22:18
@alfonsorr alfonsorr requested a review from a team as a code owner April 10, 2022 22:18
@github-actions github-actions bot added spark_3.0 PR changes to spark 3.0 spark_3.1 PR changes to spark 3.1 spark_3.2 PR changes to spark 3.2 labels Apr 10, 2022
@alfonsorr alfonsorr force-pushed the feature/cats_correct_imports branch from f3f3f89 to cb9e8cc Compare April 11, 2022 08:09
@codecov
Copy link

codecov bot commented Apr 11, 2022

Codecov Report

Merging #206 (e03a21e) into main (5159ac7) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #206   +/-   ##
=======================================
  Coverage   95.99%   95.99%           
=======================================
  Files          49       49           
  Lines         798      798           
  Branches       11       11           
=======================================
  Hits          766      766           
  Misses         32       32           
Flag Coverage Δ
spark-3.0.x 94.82% <ø> (ø)
spark-3.1.x 95.97% <ø> (ø)
spark-3.2.x 95.97% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
core/src/main/scala/doric/DoricColumn.scala 77.14% <ø> (ø)
core/src/main/scala/doric/DoricJoinColumn.scala 80.00% <ø> (ø)
...ore/src/main/scala/doric/JoinSideDoricColumn.scala 100.00% <ø> (ø)
core/src/main/scala/doric/sem/TransformOps.scala 75.00% <ø> (ø)
...c/main/scala/doric/syntax/AggregationColumns.scala 100.00% <ø> (ø)
...re/src/main/scala/doric/syntax/BinaryColumns.scala 100.00% <ø> (ø)
...re/src/main/scala/doric/syntax/StringColumns.scala 100.00% <ø> (ø)
...src/main/scala/doric/syntax/TimestampColumns.scala 80.00% <ø> (ø)
core/src/main/scala/doric/syntax/TypeMatcher.scala 100.00% <ø> (ø)
core/src/main/scala/doric/syntax/WhenBuilder.scala 100.00% <ø> (ø)
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5159ac7...e03a21e. Read the comment docs.

@alfonsorr alfonsorr mentioned this pull request Apr 11, 2022
5 tasks
eruizalo
eruizalo previously approved these changes Apr 11, 2022
@eruizalo eruizalo dismissed their stale review April 11, 2022 13:24

LGTM, pending to review all the checks to be able to build doric with spark 2.4.x

@alfonsorr alfonsorr force-pushed the feature/cats_correct_imports branch from 95ae677 to 5f590dd Compare April 11, 2022 14:38
Sbt prepared for 2.4 version
@alfonsorr alfonsorr merged commit e34607e into hablapps:main Apr 11, 2022
@alfonsorr alfonsorr deleted the feature/cats_correct_imports branch April 11, 2022 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
spark_3.0 PR changes to spark 3.0 spark_3.1 PR changes to spark 3.1 spark_3.2 PR changes to spark 3.2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants