Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cross build doric from Spark 3.0 to 3.2 #184

Merged
merged 6 commits into from
Mar 3, 2022

Conversation

alfonsorr
Copy link
Member

Description

This pull request allows to pass to sbt sparkVersion parameter to select the spark version from 3.0 to 3.2. Compiling and testing is

Related Issue

#159

Motivation and Context

Allow to use doric with any 3.x version with all the available functionality.

How Has This Been Tested?

Launched for all spark versions

  • This pull request contains appropriate tests?

@alfonsorr alfonsorr requested a review from a team as a code owner March 1, 2022 21:07
@alfonsorr alfonsorr requested a review from eruizalo March 1, 2022 21:07
@codecov
Copy link

codecov bot commented Mar 1, 2022

Codecov Report

Merging #184 (b5ca782) into main (7e0a7f7) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #184      +/-   ##
==========================================
+ Coverage   95.95%   95.97%   +0.02%     
==========================================
  Files          43       48       +5     
  Lines         790      794       +4     
  Branches       11       10       -1     
==========================================
+ Hits          758      762       +4     
  Misses         32       32              
Impacted Files Coverage Δ
...re/src/main/scala/doric/syntax/BinaryColumns.scala 100.00% <ø> (ø)
...e/src/main/scala/doric/syntax/BooleanColumns.scala 100.00% <ø> (ø)
...e/src/main/scala/doric/syntax/NumericColumns.scala 100.00% <ø> (ø)
...re/src/main/scala/doric/syntax/StringColumns.scala 100.00% <ø> (ø)
...c/main/scala/doric/syntax/AggregationColumns.scala 100.00% <100.00%> (ø)
...ore/src/main/scala/doric/syntax/ArrayColumns.scala 100.00% <100.00%> (ø)
....0_3.1/scala/doric/syntax/BinaryColumns30_31.scala 100.00% <100.00%> (ø)
..._3.1/scala/doric/syntax/AggregationColumns31.scala 100.00% <100.00%> (ø)
...park_3.1/scala/doric/syntax/BooleanColumns31.scala 100.00% <100.00%> (ø)
...park_3.1/scala/doric/syntax/NumericColumns31.scala 100.00% <100.00%> (ø)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7e0a7f7...b5ca782. Read the comment docs.

@eruizalo eruizalo linked an issue Mar 2, 2022 that may be closed by this pull request
3 tasks
@eruizalo eruizalo added enhancement New feature or request breaking 💣 Breaking changes labels Mar 2, 2022
@eruizalo eruizalo mentioned this pull request Mar 2, 2022
3 tasks
@eruizalo eruizalo removed the breaking 💣 Breaking changes label Mar 2, 2022
Sbt now accepts sparkVersion for full version (x.x.x) and sparkShortVersion (x.x)
@eruizalo eruizalo added spark_3.0 PR changes to spark 3.0 spark_3.1 PR changes to spark 3.1 spark_3.2 PR changes to spark 3.2 labels Mar 2, 2022
@alfonsorr alfonsorr requested a review from eruizalo March 2, 2022 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request spark_3.0 PR changes to spark 3.0 spark_3.1 PR changes to spark 3.1 spark_3.2 PR changes to spark 3.2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Spark version matrix
2 participants