You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@raulraja@javierfs89 Puretest currently supports finally tagless implementations, so we tried it first to adapt the finally tagless tests of freestyle, and give them a simple interpretation with either. This seems to work. Then, we gave also an instance for FreeS, though we were not able to come up with a clean implementation. Surely, this can be significantly improved. Anyway, IMO, the right approach to support Free is through a new implementation of the Puretest DSL in terms of freestyle's @free.
@jserranohidalgo Awesome!. For the @free based impl. Do you guys plan on providing modules for the different integrations with scala libs such as freestyle in the hablapps org or would you prefer if we have a freestyle-puretest in our org that includes this new version of the DSL?
@raulraja Puretest could be extended in two major dimensions: DSL technique and testing framework. It'd be nice if all extensions could be managed and advertised through the same repo. So, I lean towards adding the new implementation of the Puretest DSL for @free in the very same puretest-cats project (or in a new sbt project of the same repo, if you like). Please, feel free to suggest any change in the layout and package naming to better accommodate that contribution. I'm looking forward to it! :)
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WIP. Not actually intended to be merged.
@raulraja @javierfs89 Puretest currently supports finally tagless implementations, so we tried it first to adapt the finally tagless tests of freestyle, and give them a simple interpretation with either. This seems to work. Then, we gave also an instance for FreeS, though we were not able to come up with a clean implementation. Surely, this can be significantly improved. Anyway, IMO, the right approach to support Free is through a new implementation of the Puretest DSL in terms of freestyle's @free.