Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HCCore first pull request #176

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

EmperorNumerius
Copy link

I wanted to get into java mod/plugin making and so i decided to start simple by creating some new advancements
i mostly copied the code from other advancements and used bing when needed for help
i hope they are cool lol

Changed the command to make you active command to be /notafk instead of /afk
NEW advancement: Master mob Slayer Achieved by killing Each hostile mob 10 times
Nerw advancement
mine 10 pieces of obsidian by hand
no sleep
gotten by not sleeping for a full week
@456dev
Copy link
Collaborator

456dev commented May 16, 2024

Hi, thanks for the pr
Currently the build is failing because of a couple of errors while building

  • in java, the classes need to be the same as the files they are in so either no sleep, or sleepless, not both.
  • material.bed isn't a valid material in modern versions, instead there are ones with colours like RED_BED

@EmperorNumerius
Copy link
Author

YAY!!!!!!
it worked
and i actually understand what the code does!!!!!!!!!!!!

456dev
456dev previously requested changes May 16, 2024
Copy link
Collaborator

@456dev 456dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall good, just needs some slight changes

updated to refer to the fixes that were made by 456dev
Copy link
Collaborator

@polypixeldev polypixeldev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the advancements!! In order to get them to show up in the advancements panel, you'll have to add them in the registerAdvancements() method of HCCorePlugin.java

.announceChat()
.showToast()
.description("Kill EVERY hostile Mob 10 times");
static final int maxProgression = 640; // 10 times for each of the 64 hostile mobs
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldn't this mean that I could just kill 640 endermen in a farm and get the advancement?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i dont know
i thought it meant that you need to kill 10 of each hostile mob to get the advancement

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm I haven't tested it, but from what I see, it's not tracking how many of each mob you've killed, just how many mobs in total

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@polypixeldev i dont know how to make it count 10 of each mob death tho...

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, this is a bit of a tough one to do. The only way I can think of would be to add a map to the PlayerData class which stores how many of each mob they've killed, and update it accordingly in the EntityDeathEvent handler.

@456dev 456dev dismissed their stale review May 17, 2024 20:45

changes addressed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants