Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ashes Business Card #763

Merged
merged 14 commits into from
Jul 22, 2024
Merged

Ashes Business Card #763

merged 14 commits into from
Jul 22, 2024

Conversation

TheNewsYorkTime
Copy link
Contributor

Submission Checklist:

  • [*] I am a current high school, middle school, or home schooled student.

  • [*] I have joined the #electronics channel on Slack

  • [*] I made this board from scratch, even if I followed a tutorial

  • [*] I have followed the directions in README.md

    • [*] Created a folder under onboard/projects
    • [*] Filled out TEMPLATE.md as README.md inside your project folder
    • [*] Uploaded gerber.zip and schematic.pdf inside your project folder
    • [*] Created a folder called src and uploaded design files
    • [*] Uploaded screenshot of PCB order called cart.png with all costs included
    • [*] I am ordering the smallest batch size (ie. JLCPCB's smallest order is for 5 boards)
    • [*] If outside the US I've checked that I can afford the customs charges in my country (which isn't covered by the grant)
  • [*] (Optional) This project is from a tutorial1.

  • (Optional) This project is for the Trail.

  • (Optional) I'm in a FIRST (FRC, FTC, FLL, etc.) team. The number is: ____

Meow

Footnotes

  1. Projects from a tutorial are 100% fine! We just want to ask so we can count how people are using tutorials.

@prophetorpheus
Copy link
Collaborator

prophetorpheus commented Jul 1, 2024

Hi, I'm Orpheus Leap! Here to help you review your PR.

projects/Ashes Hacker Card:

Required files

README.md A description of your project
cart.png cart.png
gerber.zip
schematic.pdf Manually check schematic.pdf
Source files - EasyEDA Found both PCB and SCH files

You can view a render of your board over on gerber.zip/2d!

Happy OnBoarding!
This bot is a simpler helper for common submission types. If there's an error with this, please point it out and someone from the OnBoard team will look at it manually.

@TheNewsYorkTime
Copy link
Contributor Author

TheNewsYorkTime commented Jul 1, 2024

Hi, I'm Orpheus Leap! Here to help you review your PR.

Cannot find a file describing your project called "README.md". Happy OnBoarding! This bot is a simpler helper for common submission types. If there's an error with this, please point it out and someone from the OnBoard team will look at it manually.

It's there?
EDIT: File name typo

@LimesKey LimesKey self-assigned this Jul 3, 2024
@LimesKey LimesKey self-requested a review July 3, 2024 04:00
Copy link
Collaborator

@LimesKey LimesKey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything is good except the cart.png image is of the ordering process and not the finished unpaid completed order, if you go back to JLCPCB and go to the past orders page you can take a picture of that and upload it as your cart.png instead. Take a look at other pull requests as an example, let me know if you get stuck.

@TheNewsYorkTime
Copy link
Contributor Author

Ok, I think I fixed it

Copy link
Collaborator

@LimesKey LimesKey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new cart.png is not what we're looking for, please take a look at other pull requests for an example. Here's some instructions,

Thanks for submitting your PCB order! However, it looks like you took a picture of your cart instead of completing the checkout process. To ensure your order gets processed correctly, please follow the steps in this guide or in here:

  1. Click "Secure Checkout": After adding your PCB to the cart, make sure to click "Secure Checkout."
  2. Enter your shipping information: Fill in your shipping details as prompted.
  3. Take a screenshot of your unpaid order: Once you reach the final page before payment, take a screenshot of this page. It should show all the details of your order.

Please send me a screenshot of your unpaid order instead of a picture of your cart, and upload it as cart.png. This will help us review your order more efficiently. Congrats on making the PCB though!

@TheNewsYorkTime
Copy link
Contributor Author

Ok, I think I fixed it
This looks better.

Copy link
Collaborator

@LimesKey LimesKey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm having issues viewing your proof of high school enrollment, can you resubmit the verification form? You uploaded a .html file last time, please upload preferably a png or pdf.

@TheNewsYorkTime
Copy link
Contributor Author

TheNewsYorkTime commented Jul 4, 2024 via email

@LimesKey LimesKey added the Submission New Boards! label Jul 5, 2024
Copy link
Collaborator

@LimesKey LimesKey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, thanks for the ID, not sure why Airtables was acting up, it appears to be some issue with Firefox? Anyways, I've updated your ID for you so that's all good, but I'd recommend deleting your message with your student ID from GitHub since it can be sensitive information.

I did notice a possible issue with your PCB though, I could be wrong but I believe you're bridging the LA/LB traces of the NFC antenna together with the VIA through the large unsolder masked QR code you have at the back. Here's some photos, Screenshot from 2024-07-05 01-14-50
Screenshot from 2024-07-05 01-14-32
Even if this is not a problem, I'd recommend not having a large copper trace (the QR code) so close to the antenna as that may cause issues, it's unlikely but I'd just update it anyway and move the QR code a little further way or vice-versa with the antenna.

Copy link

Hi, if you need any assistance, please don't hesitate to ask here or in #electronics on Slack. This pull request is being marked as 'Stalled' for now and will be closed in 3 days if there is no activity.

@github-actions github-actions bot added the Stalled In progress, waiting for update from user or reviewer label Jul 12, 2024
@TheNewsYorkTime
Copy link
Contributor Author

Sorry It's been so long, but I think I fixed the Qr Code issue.

Copy link
Collaborator

@LimesKey LimesKey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @TheNewsYorkTime!

I've just sent you your grant for OnBoard. You should have received an invite in your email. There will be instructions on how to use your debit card attached should you need them. Please remember to upload your receipts when you make purchases.

Also, unfortunately, we're unable to offer support with reimbursements for customs fees, including reimbursements using leftover grant funds. Please keep this in mind before you make any purchases. More info in the OnBoard community shipping doc.

I'm looking forward to seeing your PCB be manufactured! Send pictures in the #electronics channel on Slack once you get it! Please don't hesitate to reach out if you have any questions!

@LimesKey LimesKey merged commit ae47136 into hackclub:main Jul 22, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Stalled In progress, waiting for update from user or reviewer Submission New Boards!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants