Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add event-specific Slack link #9

Merged
merged 1 commit into from
May 22, 2024
Merged

Conversation

DillonB07
Copy link
Contributor

Just adds the ?event= query param to the Slack invite to show the event name on the slack invite page like so:
image

Copy link

vercel bot commented May 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
boreal ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 22, 2024 7:54pm

@faisalsayed10 faisalsayed10 merged commit 16ca5f3 into hackclub:main May 22, 2024
2 checks passed
Copy link
Member

@sampoder sampoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should hold off on doing this at the moment; it requires some changes to https://github.com/hackclub/toriel. cc: @tregsthedev

@faisalsayed10
Copy link
Member

faisalsayed10 commented May 22, 2024

Sorry, had to revert it for the moment until toriel's fixed

@radioblahaj
Copy link
Member

radioblahaj commented May 23, 2024 via email

@faisalsayed10
Copy link
Member

@DillonB07 do you wanna open a PR again? i think the issue has been fixed and we can re-add it (?event=boreal)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants