Update ttl: 1 to ttl: 600 on all things as per DNS guidelines #1142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@grymmy this looks like a you thing to review :) |
alx-alexpark
approved these changes
Apr 27, 2024
|
What DNS guidelines are these in service of and why? |
|
You can just set it as the default. |
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
|
That won't fix the records that already have an incorrect TTL set. This PR is still necessary to bring records into alignment with policy. |
|
Yeah but then you don't have to repeat the same thing for every record, you can just remove it. |
|
Superseded by #1149 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.