Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scrappy didn’t reset my Slack status after I broke my streak #36

Closed
zachlatta opened this issue Jun 28, 2020 · 3 comments
Closed

Scrappy didn’t reset my Slack status after I broke my streak #36

zachlatta opened this issue Jun 28, 2020 · 3 comments

Comments

@zachlatta
Copy link
Member

Here’s what happened:

  1. Posted on Thursday (day 1 of streak). Slack status got set.
  2. Posted on Friday (day 2 of streak). Slack status got set
  3. Forgot to post on Saturday (would have been day 3).
  4. Notice at 2:56 PM ET on Sunday that Scrappy hasn’t removed my streak from my Slack status.
  5. Toggle my streak showing with /scrappy displaystreaks (ran twice). Notice that since I missed my post yesterday, my Slack status didn’t get set to anything as expected
@MatthewStanciu
Copy link
Member

I've noticed that occasionally Scrappy doesn't properly increment people's statuses when they post, which leads me to believe that the issue is with my setStatus() method. I believe this can be fixed by awaiting the API call to Slack in the function, which I just added. I can't be sure the issue was fixed, though, because it happens so rarely and sporadically that I can't feasibly reproduce it.

To keep the Issues tab clean, I'm going to go ahead and close the issue—but @zachlatta if you notice your or other people's statuses not being properly updated, please reopen and I'll investigate further. I'll also be on the lookout and reopen if needed.

@MatthewStanciu
Copy link
Member

Looks like it didn't reset my streak either :( looking into this today

@MatthewStanciu
Copy link
Member

Closing again because I'm pretty sure this time the issue was #46. Will reopen if I see it happen again though

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants