Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clutter in the top bar. #1453

Open
leomcelroy opened this issue Feb 23, 2024 · 19 comments
Open

Clutter in the top bar. #1453

leomcelroy opened this issue Feb 23, 2024 · 19 comments
Labels
bug Something isn't working good first issue Good for newcomers medium priority

Comments

@leomcelroy
Copy link
Collaborator

leomcelroy commented Feb 23, 2024

These buttons getting added to the top bar are starting to clutter the interface. Please move I'm stuck, dark, and run on device to the drop down menu. Also make the drop down menu open on hover instead of click.

Screenshot 2024-02-23 at 4 24 24 PM
@leomcelroy leomcelroy added the bug Something isn't working label Feb 23, 2024
@JosiasAurel
Copy link
Contributor

I think the "I'm stuck", "Run on Device" and "Share" button are quick actions that Sprig users will use often and should be maintained on the top bar.

@JosiasAurel
Copy link
Contributor

@grymmy what do you think?

@JosiasAurel JosiasAurel assigned grymmy and unassigned JosiasAurel Feb 27, 2024
@Sheepy3
Copy link
Contributor

Sheepy3 commented Feb 29, 2024

imo "run on device", "im stuck", and "share" are important to have immediately available, while dark mode and github could be relegated to a dropdown

@cskartikey
Copy link
Member

Assign me the issue!

@GalaxyGamingBoy
Copy link
Member

Hi! Is there any progress on this issue so far?

@JosiasAurel
Copy link
Contributor

@GalaxyGamingBoy feel free to send a PR regarding this issue if @cskartikey hasn't done one already.

@cskartikey
Copy link
Member

There's some progress, but I don't think so I'll be able to verify it until after my APs end

@cskartikey
Copy link
Member

If I get time today I'll PR

@grymmy
Copy link
Contributor

grymmy commented May 15, 2024

How does this issue reconcile with #1559?

@leomcelroy
Copy link
Collaborator Author

Discussed this on Slack this issue should cover #1559

@Cosmin-Mare
Copy link
Collaborator

Is anyone working on this rn? if not, I can do it

@JosiasAurel
Copy link
Contributor

you can pick it @Cosmin-Mare

@JosiasAurel JosiasAurel added the good first issue Good for newcomers label Jun 17, 2024
@Patcybermind
Copy link
Contributor

image
hey just asking, what happened to dark mode and im stuck?

@JosiasAurel
Copy link
Contributor

JosiasAurel commented Jun 18, 2024

dark mode is still around. (click the brush-looking icon)
image

also "I'm Stuck" has been rebranded to "Report a bug" as the needs have changed

@JosiasAurel
Copy link
Contributor

woops mistake

@Patcybermind
Copy link
Contributor

ah ok then ill put that in the hover menu

@Patcybermind
Copy link
Contributor

Patcybermind commented Jun 19, 2024

so i did the hover menu thing now im moving on to moving stuff to the dropdown menu but what stuff precisely should i move just the github and theme menu?
image

@Patcybermind
Copy link
Contributor

@leomcelroy what do you think about it?

@Patcybermind
Copy link
Contributor

#1801
this pr makes the menu open on hover

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers medium priority
Projects
None yet
Development

No branches or pull requests

8 participants