Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move firebase functionality out of /lib/game-saving/account.ts into its own file #1596

Open
Cosmin-Mare opened this issue Apr 19, 2024 · 1 comment
Open

Move firebase functionality out of /lib/game-saving/account.ts into its own file #1596

Cosmin-Mare opened this issue Apr 19, 2024 · 1 comment
Assignees
@GalaxyGamingBoy
Labels
tech debt

Comments

@Cosmin-Mare
Copy link
Collaborator

At the moment, all the firebase API functionality is inside /lib/game-saving/accounts.ts and it should be its own lib file(dbUtils.ts), because other future functionality involving the db may not directly involve game-saving, or accounts.
@JosiasAurel
Copy link
Contributor

JosiasAurel commented Apr 26, 2024 •
edited
Loading

i would advocate for using a filename firebase.ts instead

@GalaxyGamingBoy GalaxyGamingBoy self-assigned this May 1, 2024
@GalaxyGamingBoy GalaxyGamingBoy mentioned this issue May 1, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@GalaxyGamingBoy GalaxyGamingBoy

Labels
tech debt
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Seperate firebase from accounts.ts to firebase.ts GalaxyGamingBoy/hc-sprig
3 participants
@JosiasAurel @GalaxyGamingBoy @Cosmin-Mare