Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Seperate firebase from accounts.ts to firebase.ts #1638

Closed

Conversation

GalaxyGamingBoy
Copy link
Member

closes #1596

Copy link

vercel bot commented May 1, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sprig ❌ Failed (Inspect) Jun 13, 2024 0:51am

Copy link

vercel bot commented May 1, 2024

@GalaxyGamingBoy is attempting to deploy a commit to the Hack Club Team on Vercel.

A member of the Team first needs to authorize it.

@vercel vercel bot temporarily deployed to Preview – sprig May 1, 2024 19:13 Inactive
@GalaxyGamingBoy
Copy link
Member Author

Plagiarism Checker failing because of multiple js files being inputted

Copy link
Contributor

@JosiasAurel JosiasAurel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please have you tested and made sure the application works properly across?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it would be ideal if you don't include unrelated changes in a PR

Copy link
Member Author

@GalaxyGamingBoy GalaxyGamingBoy May 27, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change of the games was due to having my main branch as the origin. The change was also warranted because without it the build failed. It would be more ideal if sprig didn't crash

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move firebase functionality out of /lib/game-saving/account.ts into its own file
3 participants