Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added UI + Save System #1640

Merged
merged 5 commits into from
Jun 24, 2024
Merged

Added UI + Save System #1640

merged 5 commits into from
Jun 24, 2024

Conversation

DevIos01
Copy link
Member

@DevIos01 DevIos01 commented May 2, 2024

Simple UI implementation for key-binding system and saving changes on cookies.

image
image
image

The backend for this script will be PR on https://github.com/hackclub/sprig-engine so I am keeping this on draft till the PR on that is live / approved

@DevIos01 DevIos01 self-assigned this May 2, 2024
Copy link

vercel bot commented May 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sprig ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 24, 2024 8:21am

@DevIos01 DevIos01 marked this pull request as draft May 2, 2024 15:55
@leomcelroy
Copy link
Collaborator

This looks good. Couple questions.

  • Does it matter if the letter is capital?
  • Can you verify if it's a valid key?
  • Can you show what it's currently set to by default?

@JosiasAurel
Copy link
Contributor

@DevIos01 please resolve conflicts here

Copy link
Contributor

@JosiasAurel JosiasAurel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

bunch of good stuff
@JosiasAurel JosiasAurel merged commit 730cabc into main Jun 24, 2024
2 checks passed
@JosiasAurel JosiasAurel deleted the rebinding-key-bindings branch June 24, 2024 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants