Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make the screen keep it's aspect ratio when resizing help pane #1684

Merged
merged 6 commits into from
Jun 25, 2024

Conversation

JosiasAurel
Copy link
Contributor

addresses #1657

Copy link

vercel bot commented May 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sprig ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 25, 2024 10:02am

@vercel vercel bot temporarily deployed to Preview – sprig May 16, 2024 11:43 Inactive
@JosiasAurel
Copy link
Contributor Author

here's a screen recording of how it looks like

Screen.Recording.2024-05-16.at.12.43.38.mov

@GalaxyGamingBoy GalaxyGamingBoy linked an issue May 16, 2024 that may be closed by this pull request
@leomcelroy
Copy link
Collaborator

That doesn't seem quite right. The top of the help section should always be the bottom of the view window.

@vercel vercel bot temporarily deployed to Preview – sprig May 17, 2024 12:00 Inactive
@JosiasAurel
Copy link
Contributor Author

JosiasAurel commented May 17, 2024

i looked at how Blot's resizing feature work. i didn't move the screen controls however... is this better?

Screen.Recording.2024-05-17.at.13.00.16.mov

@leomcelroy
Copy link
Collaborator

Still not there. The bottom right panel is getting dragged over the top right.

@vercel vercel bot temporarily deployed to Preview – sprig May 22, 2024 08:57 Inactive
@JosiasAurel
Copy link
Contributor Author

game-resize.mp4

@JosiasAurel JosiasAurel merged commit b27797f into main Jun 25, 2024
2 checks passed
@JosiasAurel JosiasAurel deleted the feat/game-resize branch June 25, 2024 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Game window resizes improperly with pane resizing
2 participants