send a new copy of the code to the server only when the code changes #1687
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…anges previously the client chat feature will send 2 requests to the llm api. the first being a copy of the current code and then the chat message sent by the user. with these changes, we hash the code and only send a new copy of the code to the server when the hash of the current code in the editor is different from the previous one.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
JosiasAurel
changed the title
grymmy
reviewed
May 20, 2024
| const newCodeHash = await sha256Hash(codeMirror.value?.state.doc.toString()!); | ||
| if (newCodeHash !== codeHash) { | ||
| setCodeHash(newCodeHash); | ||
| await sendMessage(newSystemMessage.content); |
There was a problem hiding this comment.
do we fail gracefully if this fails...?
There was a problem hiding this comment.
it'll only set the code hash if the request is successful.
there error will also be bubbled-up and handle in the top-level try-catch
grymmy
approved these changes
May 20, 2024
will also set code hash only if the the request was successful|
previously there were instances where the user message will reach the server before the code from the user got there (promises shenanigans). now, the message will be sent only if the code reached the server successfully otherwise it fails and bubbles the error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
previously the client chat feature will send 2 requests to the llm api. the first being a copy of the current code and then the chat message sent by the user.
with these changes, we hash the code and only send a new copy of the code to the server when the hash of the current code in the editor is different from the previous one.