-
Notifications
You must be signed in to change notification settings - Fork 730
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rossy road #1694
Open
kingzilla54
wants to merge
9
commits into
hackclub:main
Choose a base branch
from
kingzilla54:main
base: main
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
rossy road #1694
+1,312
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@kingzilla54 is attempting to deploy a commit to the Hack Club Team on Vercel. A member of the Team first needs to authorize it. |
grymmy
requested changes
May 21, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fun game!
Two things:
- Please modify the path of your game to be in the games directory.
- Please modify the screenshot of your game to be in line with requirements (should be in games/img, with same filename as game)
- There is a minor issue w/ the definition of one of the bitmaps that makes the code not run in the sprig editor. I was able to fix it to play the game (which was fun) but it needs updating here in this pr.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
high priority
initial review performed
This Sprig app PR has had initial feedback given, and is in a pending state of review
submission
Game submission
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Your checklist for this pull request
Author name Tristan
Author: Tristan
ZillaAbout your game
**What is your game about?**roads
**How do you play your game?**cross roads
Code
Check off the items that are true.
/games
directory.-
s, or_
s.Image (If an image is used)
/games/img
directory.