Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bug with > 6 items in weapon construction #779

Merged
merged 1 commit into from
Jul 12, 2024
Merged

Fix bug with > 6 items in weapon construction #779

merged 1 commit into from
Jul 12, 2024

Conversation

toberge
Copy link
Contributor

@toberge toberge commented Jul 11, 2024

Closes #758

@toberge toberge changed the title wip fix bug Fix bug with > 6 items in weapon construction Jul 11, 2024
@toberge toberge marked this pull request as ready for review July 11, 2024 18:17
@toberge toberge requested a review from Fueredoriku July 11, 2024 18:17
Fueredoriku
Fueredoriku requested changes Jul 12, 2024
View reviewed changes
Copy link
Contributor

@Fueredoriku Fueredoriku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remember to also invert the direction of the background lines:
Down direction currently moves background lines wrong direction, and up direction no longer animates background lines

@toberge toberge requested a review from Fueredoriku July 12, 2024 21:12
@toberge
Refactor ItemSelectSlot to fix bug with > 6 items of a type
4a2cffc 
Also makes the order more sensible by duplicating the entire list of
items if we have less than the number of slots.
Fueredoriku
Fueredoriku approved these changes Jul 12, 2024
View reviewed changes
Copy link
Contributor

@Fueredoriku Fueredoriku left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good and now works as expected 👍

@toberge toberge merged commit 011c605 into dev Jul 12, 2024
@toberge toberge deleted the fix/item-select-slot-bug branch July 12, 2024 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fueredoriku Fueredoriku Fueredoriku approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Prosjekt-Spill-H22 board
Status: Done 🎉
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Gamebreaking bug in weapon select
2 participants
@toberge @Fueredoriku