Fix misc. #49
Merged
Fix misc. #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It might be a better idea to move the enums to separate files, but this will do for now.
Also reordered some of the overridden methods, so that they appear in the same order as in the abstract class.
This removes the need to check whether an element exists in the set, which is fairly inefficient compared to just using a set.
This makes the value of `CurrentState` visible in the inspector, but unable to be written to.
This fixes a bug that let the player change the direction of nearby towers while in the turret selection menu.
ddabble
requested review from
SondreHus,
Fueredoriku,
jesper2k and
ThomasJGabrielsen
Fueredoriku
approved these changes
Oct 12, 2021
SondreHus
reviewed
Oct 12, 2021
# Conflicts: # Assets/Scripts/Player/PlayerStateController.cs # Assets/Scripts/Player/PlayerUi.cs
ddabble
requested review from
ThomasJGabrielsen,
SondreHus and
Fueredoriku
and removed request for
ThomasJGabrielsen
Fueredoriku
approved these changes
Oct 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Highlights:
Backbutton toCancel, and changed the key to Esc (b33da98)