Fix/bugfix #72
Merged
Fix/bugfix #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Created a custom comparator and restructured how highscores are saved so they can be easily sorted.
Added ability to pause individual sources as well as lower the general volume of the AudioListener.
Fueredoriku
requested changes
Feb 16, 2022
There was a problem hiding this comment.
There seems to be compilation errors tied to loading and adding highscores on the leaderboard.
Also, regarding the changes to PauseManager:
This array:
public AudioSource[] audioSources;
and this functionality:
// Pause every audiosource in array. foreach(AudioSource a in audioSources) { if (IsPaused) a.Pause(); else a.UnPause(); } // Reduce the listener volume level AudioListener.volume = IsPaused ? 0.3f : 1f;
should be implemented in and derived from the audioManager singleton.
Changed "Endie"'s score to 10 so that no score on the leaderboard is 0
ddabble
requested changes
Feb 18, 2022
Closed
# Conflicts: # Assets/Scripts/GameState/GameOverScreen.cs
ddabble
approved these changes
Feb 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed the following:
Pause menu does not pause music
Saving a new highscore populates the leaderboard with only that score